On Thu, 20 Sep 2012 10:27:17 +0800 Shaohua Li <shli@xxxxxxxxxx> wrote: in which wrong sectors were trimmed.... > > Ok, just confirmed, delete raid5_compute_sector is ok if I adjust > logical_sector calculation. Here is the new patch. > Thanks. That looks better. I've applied it with some minor formatting changes. I then went to look at the follow-up page and ..... I count 11 separate places where you test the new flag and possibly memset a page to zero. This doesn't seem like an improvement to me. Why don't we just mark the page as not up-to-date when we discard it? That would avoid storing inconsistent data, and would avoid needing to zero pages. NeilBrown
Attachment:
signature.asc
Description: PGP signature
