Re: [PATCH] md/bitmap:Don't use IS_ERR to judge alloc_page().

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, 15 Sep 2012 10:43:00 +0800 "Jianpeng Ma" <majianpeng@xxxxxxxxx> wrote:

> Signed-off-by: Jianpeng Ma <majianpeng@xxxxxxxxx>
> ---
>  drivers/md/bitmap.c |    7 ++-----
>  1 file changed, 2 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c
> index 94e7f6b..f03ad11 100644
> --- a/drivers/md/bitmap.c
> +++ b/drivers/md/bitmap.c
> @@ -476,11 +476,8 @@ static int bitmap_new_disk_sb(struct bitmap *bitmap)
>  	int err = -EINVAL;
>  
>  	bitmap->storage.sb_page = alloc_page(GFP_KERNEL);
> -	if (IS_ERR(bitmap->storage.sb_page)) {
> -		err = PTR_ERR(bitmap->storage.sb_page);
> -		bitmap->storage.sb_page = NULL;
> -		return err;
> -	}
> +	if (bitmap->storage.sb_page == NULL)
> +		return -ENOMEM;
>  	bitmap->storage.sb_page->index = 0;
>  
>  	sb = kmap_atomic(bitmap->storage.sb_page);

Applied,
Thanks,
NeilBrown

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux