Re: [PATCH] md/raid5:Add "BlockedBadBlocks" flag when waitting rdev to be unlocked.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 27 Jun 2012 13:45:13 +1000 NeilBrown <neilb@xxxxxxx> wrote:


> Thanks for finding this.  However I don't think your patch is quite correct.
> It would re-introduce a hang fixed by commit 43220aa0f22cd3ce5b3.
> 
> I've applied the following instead.
> 
....
> +		else
> +			/* Internal metadata will immediately
> +			 * be written by raid5d, so we don't
> +			 * need to wait here.
> +			 */
> +			rdev_dec_pending(rdev, mddev);
> +	}

... which is clearly wrong.  That last line is now

                        rdev_dec_pending(s.blocked_rdev, conf->mddev);

NeilBrown


>  
>  	if (s.handle_bad_blocks)
>  		for (i = disks; i--; ) {

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux