Re: About raid5 read error handle when raid5 was degraded.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 21 May 2012 18:47:58 +0800 "majianpeng" <majianpeng@xxxxxxxxx> wrote:

>  Hi all:
> 	I readed the latest code in function :
> 
> raid5_end_read_request():
> >>	else if (conf->mddev->degraded >= conf->max_degraded)
> >>			printk_ratelimited(
> >>				KERN_WARNING
> >>				"md/raid:%s: read error not correctable "
> >>				"(sector %llu on %s).\n",
> >>				mdname(conf->mddev),
> >>				(unsigned long long)(sh->sector
> >>						     + rdev->data_offset),
> >>				bdn);
> 
> If this occur,then exec md_error().In md_error(), remove this disk.
> The raid5 will fail and lost all data.
> Why do call rdev_set_badsector() for this situation?
> 

You are probably right - rdev_set_badblocks should probably be called there.
I've added it to my list of issues to look at when I get a chance.

Thanks,
NeilBrown

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux