On Mon, Apr 30, 2012 at 5:49 PM, NeilBrown <neilb@xxxxxxx> wrote:
> On Mon, 30 Apr 2012 13:31:41 -0700 Dan Williams <dan.j.williams@xxxxxxxxx>
> wrote:
>
>> [ adding Russell and Neil for comment about the proposed change to async_tx ]
>
> I've managed to avoid learning much about the internal details of async_tx
> and adma but I thought I'd have a quick look.
>
> Doesn't this Kconfig change simply disable ASYNC_TX_DMA on any device that
> selects ASNC_TX_ENABLE_CHANNEL_SWITCH. i.e.
> INTEL_IOP_ADMA
> FSL_DMA
> MX_XOR
> AMCC_PPC440_SPA_ADMA
> Is that what you want to do? Disable all of those?
> I guess if they don't work then that is the right thing to do....
Now that I refresh my memory on the full scope of the problem, this
change would help, but would not be sufficient. The undefined
behavior that the code currently relies on is overlapping dma-mappings
to the same buffer (happens to work on x86, known to be broken on ARM
v6). So md/raid456 and async_tx actually need to conscious of up to
three dma mapping cases:
1/ pure software raid
2/ offload to a dma domain that can handle a copy+xor/pq+validate
chain (dma map the stripe once)
2a/ single domain single channel
2b/ single domain multiple channels - channel switch but reuse the
initial dma mapping for all operations
3/ offload to collection of dma domains with differing capabilities
(channel switch + remap the stripe every time we cross a domain
boundary)
The biggest difference between 2 and 3 is that the entire chain of
operations can be prepped and submitted to hardware up front in 2, but
needs to wait for the completion of the previous operation before
re-mapping in 3.
An ulterior motive of adding "depends on
!ASYNC_TX_ENABLE_CHANNEL_SWITCH" is to elicit some help with this
rework from other driver maintainers since I'm not even sure 3 is a
configuration the current engines will present.
--
Dan
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
