On Sun, 15 Jan 2012 03:09:46 -0500 Andrei Warkentin <andrey.warkentin@xxxxxxxxx> wrote: > bitmap_new_disk_sb() would still create V3 bitmap superblock > with host-endian layout. > > Perhaps I'm confused, but shouldn't bitmap_new_disk_sb() be > creating a V4 bitmap superblock instead, that is portable, > as per comment in bitmap.h? BITMAP_MINOR was also unused. > > Signed-off-by: Andrei Warkentin <andrey.warkentin@xxxxxxxxx> > --- > drivers/md/bitmap.c | 3 --- > drivers/md/bitmap.h | 2 -- > 2 files changed, 0 insertions(+), 5 deletions(-) > > diff --git a/drivers/md/bitmap.c b/drivers/md/bitmap.c > index 045e086..e786da6 100644 > --- a/drivers/md/bitmap.c > +++ b/drivers/md/bitmap.c > @@ -568,9 +568,6 @@ static int bitmap_new_disk_sb(struct bitmap *bitmap) > bitmap->events_cleared = bitmap->mddev->events; > sb->events_cleared = cpu_to_le64(bitmap->mddev->events); > > - bitmap->flags |= BITMAP_HOSTENDIAN; > - sb->version = cpu_to_le32(BITMAP_MAJOR_HOSTENDIAN); > - > kunmap_atomic(sb); > > return 0; > diff --git a/drivers/md/bitmap.h b/drivers/md/bitmap.h > index a15436d..af588ac 100644 > --- a/drivers/md/bitmap.h > +++ b/drivers/md/bitmap.h > @@ -13,8 +13,6 @@ > #define BITMAP_MAJOR_HI 4 > #define BITMAP_MAJOR_HOSTENDIAN 3 > > -#define BITMAP_MINOR 39 > - > /* > * in-memory bitmap: > * Yes, you are exactly correct. I've applied that patch (and less than three months since you sent it - not bad [no, not bad: terrible!]) Thanks, NeilBrown
Attachment:
signature.asc
Description: PGP signature
