RE: [PATCH 1/6] imsm: avoid overflows for disks over 1TB

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > @@ -984,7 +1050,8 @@ static __u32 imsm_min_reserved_sectors(struct
> intel_super *super)
> >  {
> >  	struct extent *e;
> >  	int i;
> > -	__u32 min_active, remainder;
> > +	unsigned long long min_active;
> > +	__u32 remainder;
> 
> I'm a bit concerned that 'remainder' is still a '__u32'.  It is
> calculated as
> the difference of two 'unsigned long long'....
> I'll take the patch as is, but you might like to fix this up.

Remainder here will always be small as it is just the size of metadata.
get_extents makes sure the last extent starts close to the end of the disk.

> 
> Applied.
> 
> Thanks,
> NeilBrown

Regards
Anna
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux