On Wed, 28 Mar 2012 20:04:46 +0800 "majianpeng" <majianpeng@xxxxxxxxx> wrote:
> >From 641d71c2c1acc15536c621e2aa9806fe42b9cb8a Mon Sep 17 00:00:00 2001
> From: majianpeng <majianpeng@xxxxxxxxx>
> Date: Wed, 28 Mar 2012 20:02:05 +0800
> Subject: [PATCH] md/raid1:remove unnecessary set_bit(MD_RECOVERY_INTR,&mddev->recovery).
>
>
> Signed-off-by: majianpeng <majianpeng@xxxxxxxxx>
> ---
> drivers/md/raid1.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/md/raid1.c b/drivers/md/raid1.c
> index 4a40a20..81083f2 100644
> --- a/drivers/md/raid1.c
> +++ b/drivers/md/raid1.c
> @@ -1649,7 +1649,6 @@ static int fix_sync_read_error(struct r1bio *r1_bio)
> if (abort) {
> conf->recovery_disabled =
> mddev->recovery_disabled;
> - set_bit(MD_RECOVERY_INTR, &mddev->recovery);
> md_done_sync(mddev, r1_bio->sectors, 0);
> put_buf(r1_bio);
> return 0;
This one is unnecessary because md_done_sync set it for us,
> @@ -2403,7 +2402,6 @@ static sector_t sync_request(struct mddev *mddev, sector_t sector_nr, int *skipp
> * fail the really bad ones ???
> */
> conf->recovery_disabled = mddev->recovery_disabled;
> - set_bit(MD_RECOVERY_INTR, &mddev->recovery);
> return 0;
> } else
> return min_bad;
But why is this one unnecessary? This is why including and explanation at
the top of the patch helps.
Not applied - but I will if you explain why it is needed.
Thanks,
NeilBrown
Attachment:
signature.asc
Description: PGP signature
