On Thu, Feb 2, 2012 at 3:45 PM, <Jes.Sorensen@xxxxxxxxxx> wrote:
> From: Jes Sorensen <Jes.Sorensen@xxxxxxxxxx>
>
> Other parts of mdadm/mdmon place .pid/.sock files in MDMON_DIR. This
> makes Monitor.c consistent with the rest.
>
> Signed-off-by: Jes Sorensen <Jes.Sorensen@xxxxxxxxxx>
> ---
> Monitor.c | 8 +++++---
> 1 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/Monitor.c b/Monitor.c
> index 77f22aa..7ed5282 100644
> --- a/Monitor.c
> +++ b/Monitor.c
> @@ -294,8 +294,10 @@ static int check_one_sharer(int scan)
> int pid, rv;
> FILE *fp;
> char dir[20];
> + char path[100];
Just wondering why not something like PATH_MAX or similar constant? I
guess there should be one, though 100 should be enough
> struct stat buf;
> - fp = fopen("/var/run/mdadm/autorebuild.pid", "r");
> + sprintf(path, "%s/autorebuild.pid", MDMON_DIR);
> + fp = fopen(path, "r");
> if (fp) {
> if (fscanf(fp, "%d", &pid) != 1)
> pid = -1;
> @@ -317,12 +319,12 @@ static int check_one_sharer(int scan)
> fclose(fp);
> }
> if (scan) {
> - if (mkdir("/var/run/mdadm", S_IRWXU) < 0 &&
> + if (mkdir(MDMON_DIR, S_IRWXU) < 0 &&
> errno != EEXIST) {
> fprintf(stderr, Name ": Can't create "
> "autorebuild.pid file\n");
> } else {
> - fp = fopen("/var/run/mdadm/autorebuild.pid", "w");
> + fp = fopen(path, "w");
> if (!fp)
> fprintf(stderr, Name ": Cannot create"
> " autorebuild.pid"
> --
> 1.7.4.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
This is 2nd copy, first was sent from phone and discarded as contained HTML.
--
Best regards,
[COOLCOLD-RIPN]
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
