Re: [PATCH] Use posix_memalign() for memory used to write bitmaps

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/16/12 04:17, NeilBrown wrote:
> On Tue, 14 Feb 2012 11:52:13 +0100 Jes.Sorensen@xxxxxxxxxx wrote:
> 
>> From: Jes Sorensen <Jes.Sorensen@xxxxxxxxxx>
>>
>> This makes super[01].c properly align buffers used for the bitmap
>> using posix_memalign() to make sure the writes don't fail in case the
>> bitmap is opened using O_DIRECT.
>>
>> This is based on https://bugzilla.redhat.com/show_bug.cgi?id=789898
>> and an initial patch by Alexander Murashkin.
> 
> hi Jes,
> 
> I suspect that
> 
> http://neil.brown.name/git?p=mdadm;a=commitdiff;h=6ef89052d85b8137b8a7100f761d896ae6f61001
> 
> is the fix you want.  But I'll probably apply yours as well.
> 
> Thanks,
> NeilBrown

Hi Neil,

Thanks, I haven't been able to reproduce the problem locally that
Alexander was seeing, but I suspect you are right. That said, I'd still
vote in favor of using posix_memalign() rather than doing the pointer
juggling, less error prone.

Cheers,
Jes
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux