On Fri, 20 Jan 2012 15:05:30 +0100 Jes Sorensen <Jes.Sorensen@xxxxxxxxxx> wrote: > On 01/19/12 08:25, Kwolek, Adam wrote: > >>> If there is already a --freeze-reshape option, then I think it is > >>> > > better to have the boot scripts set that explicitly. The initramfs > >>> > > stage isn't really something we expect users or admins to mess with > >>> > > manually, so it ought to work for that. However if there is no option > >>> > > for this, and I just need to set the variable when detecting --initrd, > >>> > > then I can add that to the patchset no problem. > >> > > >> > I guess I should add here, that I am not strongly opposed to setting > >> > freeze_reshape for initrd. I am just wary of setting multiple flags magically > >> > without it being obvious to the user/admin. > >> > > >> > Cheers, > >> > Jes > > Up to you. > > Ok, I will leave it up to Neil/Kay/Harald - what do you guys think? > Should we make --initrd set the freeze_reshape flag, or better to expect > the initramfs scripts to specify it directly? > I would like to keep these two options separate. It might be worth noting in the man page that --freeze-reshape would normally be used with --whatever-we-call-the-new-flag, but I don't think they should be the same option. thanks, NeilBrown
Attachment:
signature.asc
Description: PGP signature