Re: [PATCH 2/3] Don't tell sysfs to launch the container as we are doing it ourselves

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 21 Oct 2011 15:33:19 +0200 Jes.Sorensen@xxxxxxxxxx wrote:

> From: Jes Sorensen <Jes.Sorensen@xxxxxxxxxx>
> 
> Signed-off-by: Jes Sorensen <Jes.Sorensen@xxxxxxxxxx>
> ---
>  Incremental.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/Incremental.c b/Incremental.c
> index 1a9a97b..cff7663 100644
> --- a/Incremental.c
> +++ b/Incremental.c
> @@ -446,7 +446,6 @@ int Incremental(char *devname, int verbose, int runstop,
>  	if (info.array.level == LEVEL_CONTAINER) {
>  		int devnum = devnum; /* defined and used iff ->external */
>  		/* Try to assemble within the container */
> -		sysfs_uevent(&info, "change");
>  		if (verbose >= 0)
>  			fprintf(stderr, Name
>  				": container %s now has %d devices\n",

Hi Jes,
 I've had to revert this patch as it causes a regression.

Without the 'change' event the container device doesn't get created in /dev.

I'm not sure udev should be running "--incremental" on containers anyway, but
if it does it shouldn't cause problems should it?  If it does we should fix
those problems.

Thanks,
NeilBrown

Attachment: signature.asc
Description: PGP signature


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux