Re: [PATCH] imsm: incorrect incremental behavior because of wrong index used

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Nov 23, 2011 at 8:59 AM, Przemyslaw Czarnowski
<przemyslaw.hawrylewicz.czarnowski@xxxxxxxxx> wrote:
> Incremental in some cases prematurely assembles degraded arrays due to
> wrong index used in code which counts missing disks
>
> Signed-off-by: Przemyslaw Czarnowski <przemyslaw.hawrylewicz.czarnowski@xxxxxxxxx>

Reviewed-by: Dan Williams <dan.j.williams@xxxxxxxxx>

> ---
>  super-intel.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/super-intel.c b/super-intel.c
> index 360c4cc..a0672bf 100644
> --- a/super-intel.c
> +++ b/super-intel.c
> @@ -2539,7 +2539,7 @@ static void getinfo_super_imsm(struct supertype *st, struct mdinfo *info, char *
>                 * (catches single-degraded vs double-degraded)
>                 */
>                for (j = 0; j < map->num_members; j++) {
> -                       __u32 ord = get_imsm_ord_tbl_ent(dev, i, 0);
> +                       __u32 ord = get_imsm_ord_tbl_ent(dev, j, 0);
>                        __u32 idx = ord_to_idx(ord);
>
>                        if (!(ord & IMSM_ORD_REBUILD) &&
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux