> -----Original Message----- > From: Jes.Sorensen@xxxxxxxxxx [mailto:Jes.Sorensen@xxxxxxxxxx] > Sent: Monday, October 17, 2011 10:40 PM > To: linux-raid@xxxxxxxxxxxxxxx > Cc: neilb@xxxxxxx; dledford@xxxxxxxxxx; Dorau, Lukasz; Kwolek, Adam; > Labun, Marcin > Subject: [PATCH 0/1] IMSM do not assume prev + current map in same state > means reshape > > From: Jes Sorensen <Jes.Sorensen@xxxxxxxxxx> > > Hi, > > I believe there is a bug in the current IMSM code. It makes the assumption > that if the state of the previous map and the current map are the same, it > means we are trying to reshape the array. However if you have a large array > and just installed on it, and it was still resyncing when you rebooted, it will > come up in the same state and 'mdadm -Aa' will fail with an error that it is > lacking a resync file. > > This is what prevents an update Fedora 15 system from booting, such as > https://bugzilla.redhat.com/show_bug.cgi?id=736387 > > If I am missing something here, I'd appreciate to hear about it. > > Thanks, > Jes Hi, There is bug there as you pointed in your email, but it is already fixed in Neil's repository by commit : imsm: fix: stopped resync does not continue after auto-assemblation b601104eb4a4733a838fb86e9e279fed14ce9d3f Your patch "IMSM do not assume prev + current map in same state means reshape" can break e.g chunk size migration when number of disks doesn't change. Correct fix is pointed above and it tests migration type. BR Adam > > Jes Sorensen (1): > IMSM only run reshape if number of disks has changed > > super-intel.c | 13 ++++--------- > 1 files changed, 4 insertions(+), 9 deletions(-) > > -- > 1.7.6.4 -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
