> -----Original Message----- > From: linux-raid-owner@xxxxxxxxxxxxxxx [mailto:linux-raid- > owner@xxxxxxxxxxxxxxx] On Behalf Of NeilBrown > Sent: Wednesday, September 21, 2011 4:31 AM > To: Kwolek, Adam > Cc: linux-raid@xxxxxxxxxxxxxxx; Ciechanowski, Ed; Labun, Marcin > Subject: Re: [PATCH 12/14] Early reshape backup verification > > On Fri, 16 Sep 2011 13:55:18 +0200 Adam Kwolek <adam.kwolek@xxxxxxxxx> > wrote: > > > Ever reshape needs to backup its critical section. For this purposes > > backup file or external metadata mechanisms can be used. > > This is not correct. You are right. BR Adam > For internal metadata the critical section can be stored on a spare device, and > this is preferred where possible. > > So it is not the case that you must have a backup_file for non-external data. > > NeilBrown > > > > > > Add verification if backup file or metadata mechanisms can have chance > > to restore data form backup. > > For native metadata existence of passed (from command line) backup > > file is checked. For external metadta manage_reshape() and > > recover_backup() are tested for this purposes. > > > > Signed-off-by: Adam Kwolek <adam.kwolek@xxxxxxxxx> > > --- > > > > Grow.c | 12 ++++++++++++ > > 1 files changed, 12 insertions(+), 0 deletions(-) > > > > diff --git a/Grow.c b/Grow.c > > index fa22382..d54b8a8 100644 > > --- a/Grow.c > > +++ b/Grow.c > > @@ -3667,6 +3667,18 @@ int Grow_continue_command(char *devname, > int fd, > > devname); > > return 1; > > } > > + > > + /* request backup file > > + * when no metadta specific backup action is defined > > + */ > > + if ((backup_file == NULL) && > > + ((st->ss->manage_reshape == NULL) || > > + (st->ss->recover_backup == NULL))) { > > + fprintf(stderr, Name ": Please provide backup file " > > + "for reshape continuation.\n"); > > + return 1; > > + } > > + > > dprintf("Grow continue is run for "); > > if (st->ss->external == 0) { > > dprintf("native array (%s)\n", devname); > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-raid" > > in the body of a message to majordomo@xxxxxxxxxxxxxxx More > majordomo > > info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
