Re: [PATCH] udev rules: use $tempnode, check for supported types, comments

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



W dniu 19.09.2011 05:12, NeilBrown pisze:
> 
> Thanks.
> I've applied this... though I must admit that I don't really like all the
> GOTOs - but that is really the fault of udev I expect.
> 

Yes, well - the alternative is a single bit longer line such as:

ENV{ID_FS_TYPE}!="ddf_raid_member", ENV{ID_FS_TYPE}!="isw_raid_member", ENV{ID_FS_TYPE}!="linux_raid_member", GOTO="md_inc_skip"

I thought the version with one more goto was more readable in the end,
though I also have my doubts about the choice.


> What was the rational for changing
>     ==""
> to
>     !="?*"
> 
> ??
> 

Actually none, just happened during the rewrite (both alternatives 
are functionally identical) - I guess I'm more used to "?*" checks 
for "is / isn't defined", so I didn't pay attention for it to be 
exact like before.

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux