On Mon, Sep 5, 2011 at 7:23 AM, Labun, Marcin <Marcin.Labun@xxxxxxxxx> wrote:
> Subject: [PATCH] kill-subarray: fix, cannot kill-subarray with unsupported metadata
>
> container_content retrieves volume information from disks in the container.
> For unsupported volumes the function was not returning mdinfo. When all volumes
> were unsupported the function was returning NULL pointer to block actions on the volumes.
Isn't this the purpose of ->ignore_hw_compat?
So we could do something simpler like the following instead?
diff --git a/Kill.c b/Kill.c
index b841a5b..11b27a6 100644
--- a/Kill.c
+++ b/Kill.c
@@ -97,7 +97,9 @@ int Kill_subarray(char *dev, char *subarray, int quiet)
memset(st, 0, sizeof(*st));
+ st->ignore_hw_compat = 1;
fd = open_subarray(dev, subarray, st, quiet);
+ st->ignore_hw_compat = 0;
if (fd < 0)
return 2;
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
