Re: [patch] md/raid10: double lock typo in handle_read_error()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 27 Jul 2011 12:52:02 +0300 Dan Carpenter <error27@xxxxxxxxx> wrote:

> This should be a spin_unlock_irq() instead of spin_lock_irq()
> 
> Signed-off-by: Dan Carpenter <error27@xxxxxxxxx>
> 
> diff --git a/drivers/md/raid10.c b/drivers/md/raid10.c
> index 9214e08..8b29cd4 100644
> --- a/drivers/md/raid10.c
> +++ b/drivers/md/raid10.c
> @@ -2117,7 +2117,7 @@ read_more:
>  			mbio->bi_phys_segments = 2;
>  		else
>  			mbio->bi_phys_segments++;
> -		spin_lock_irq(&conf->device_lock);
> +		spin_unlock_irq(&conf->device_lock);
>  		generic_make_request(bio);
>  		bio = NULL;
>  

Thanks!
I haven't yet submitted the patch which introduced that bug, so I just fixed
the patch directly and credited you.

Thanks,
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux