Re: [PATCH] MD: raid1 s/sysfs_notify_dirent/sysfs_notify_dirent_safe

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 14 Jul 2011 15:53:49 -0500 Jonathan Brassow <jbrassow@xxxxxxxxxx>
wrote:

> If device-mapper creates a RAID1 array that includes devices to
> be rebuilt, it will deref a NULL pointer when finished because
> sysfs is not used by device-mapper instantiated RAID devices.
> 
> Signed-off-by: Jonathan Brassow <jbrassow@xxxxxxxxxx>
> 
> Index: linux-2.6/drivers/md/raid1.c
> ===================================================================
> --- linux-2.6.orig/drivers/md/raid1.c
> +++ linux-2.6/drivers/md/raid1.c
> @@ -1027,7 +1027,7 @@ static int raid1_spare_active(mddev_t *m
>  		    && !test_bit(Faulty, &rdev->flags)
>  		    && !test_and_set_bit(In_sync, &rdev->flags)) {
>  			count++;
> -			sysfs_notify_dirent(rdev->sysfs_state);
> +			sysfs_notify_dirent_safe(rdev->sysfs_state);
>  		}
>  	}
>  	spin_lock_irqsave(&conf->device_lock, flags);
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html



Applied, thanks.

NeilBrown

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux