2011-06-23 (목), 10:55 +1000, NeilBrown: > Hi, > thanks for these. > > I have applied the first and the last. > > The two "factor out" patches conflict with some much more substantial > refactoring I have been doing in raid5.c. I have just pushed all of that > into my for-next branch: > > git://neil.brown.name/md for-next > > so you can use that as a basis for any further review. Thanks. I'll have a look at that. > > The r5_for_each_bio() patch I'm not 100% sure I'm happy with, and in any > case it would have conflicted with my other changes too. > I'm not fond of macros that hide details that could be important. A > "for_each" macro that purely and simply walks through a list is fine. A > "for_each" macro that does anything more complicated I start to have doubts > about... > However if you really do like it and want to rebase it on the for-next > branch I'll have another look and think harder about it. Maybe I'll end up > liking it after all, but no promises. I don't have any strong opinion on it. It was just a suggestion that I think it helps the code cleaner but ... Anyway, thanks for your comment. -- Regards, Namhyung Kim -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
