Re: [PATCH 1 of 9] MD: possible typo

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 23 May 2011 22:05:58 -0500 Jonathan Brassow <jbrassow@xxxxxxxxxxxxxx>
wrote:

> Patch name: md-possible-typo.patch
> 
> Fix a value printed in kiB but labeled as 'blocks'.
> 
> Signed-off-by: Jonathan Brassow <jbrassow@xxxxxxxxxx>
> 
> Index: linux-2.6/drivers/md/md.c
> ===================================================================
> --- linux-2.6.orig/drivers/md/md.c
> +++ linux-2.6/drivers/md/md.c
> @@ -6867,7 +6867,7 @@ void md_do_sync(mddev_t *mddev)
>  	 */
>  	window = 32*(PAGE_SIZE/512);
>  	printk(KERN_INFO "md: using %dk window, over a total of %llu blocks.\n",
> -		window/2,(unsigned long long) max_sectors/2);
> +		window/2, (unsigned long long) max_sectors);
>  
>  	atomic_set(&mddev->recovery_active, 0);
>  	last_check = 0;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


"blocks" has traditionally meant "kibibytes" in md nomenclature, so this was
"correct".

I'd be quite happy to change the word "blocks" to "KB" (or even "KiB") though.

NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux