Re: [PATCH 1/5] imsm: prepare update for level migrations reshape

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 29 Apr 2011 00:00:05 +0200 Przemyslaw Czarnowski
<przemyslaw.hawrylewicz.czarnowski@xxxxxxxxx> wrote:

		struct intel_dev *dv;
> @@ -7025,12 +7046,12 @@ static int imsm_create_metadata_update_for_reshape(
>  	struct supertype *st,
>  	struct geo_params *geo,
>  	int old_raid_disks,
> -	struct imsm_update_reshape **updatep)
> +	struct imsm_update_reshape_migration **updatep)
>  {

Why are you changing the type of 'updatep' for
imsm_create_metadata_update_for_reshape?

The subsequent code allocated memory based on the 'imsm_update_reshape'
structure, but then sets 'new_disk' entries based on the new structure.
That has got to be wrong.

Please review and fix this up.

NeilBrown

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux