On Mon, 21 Feb 2011 10:09:37 +0000 "Czarnowska, Anna" <anna.czarnowska@xxxxxxxxx> wrote: > >From 33fa2700b9911b0815112b223a4df7b1f1716659 Mon Sep 17 00:00:00 2001 > From: Anna Czarnowska <anna.czarnowska@xxxxxxxxx> > Date: Mon, 21 Feb 2011 10:24:26 +0100 > Subject: [PATCH] set default chunk in validate_geometry > Cc: linux-raid@xxxxxxxxxxxxxxx, Williams, Dan J <dan.j.williams@xxxxxxxxx>, Ciechanowski, Ed <ed.ciechanowski@xxxxxxxxx> > > When chunk size is not set from command line we need to guess it > depending on metadata given on command line or found on listed devices. > > Validate_geometry sets the default for it's metadata if chunk is not set. > For external metadata chunk is set only when creating in a container. > For imsm validate_geometry_imsm_orom is responsible for finding default > chunk depending on container metadata loaded. Container will already know > which controller it is attached to, and have this controllers orom > available. > do_default_chunk indicates that we need to find default chunk and > if validate_geometry fails for some metadata it tells us to reset chunk > that may have been set. > > Current solution would set default chunk correctly for imsm only if > container device was given on command line. With the list of devices > chunk was always set to 512. > > Signed-off-by: Anna Czarnowska <anna.czarnowska@xxxxxxxxx> Thanks for this Anna. Applied. NeilBrown -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
