On Fri, Feb 18, 2011 at 01:13:32AM +0100, Giovanni Tessore wrote: > On 02/17/2011 04:44 PM, Keld Jørn Simonsen wrote: > >It should be possible to run a periodic check of if any bad sectors have > >occurred in an array. Then the half-damaged file should be moved away from > >this area with the bad block by copying it and relinking it, and before > >relinking it to the proper place the good block corresponding to the bad > >block should be marked as a corresponding good block on the healthy disk > >drive, so that it not be allocated again. This action could even be > >triggered by the event of the detection of the bad block. This would > >probably meean that ther need to be a system call to mark a > >corresponding good block. The whole thing should be able to run in > >userland and somewhat independent of the file system type, except for > >the lookup of the corresponding file fram a damaged block. > > I don't follow this.. if a file has some damaged blocks, they are gone, > moving it elsewhere does not help. Remember the file is in a RAID. So you can lose one disk drive and your data is still intact. > And however, this is a task of the filesystem. No, it is the task of the raid, as it is the raid that gives the functionality that you can lose a drive and still have your data intact. the raid level knows what is lost, and what is still good, and where this stuff is. If we are then operating on the file level, then doing something clever could be a cooperation between the raid leven ald the filesystem level, as described above. > md is just a block device (more reliable than a single disk due to some > level of redundancy), and it should be indipendent from the kind of file > system on it (as the file system should be indipendent from the kind of > block device it resides on [md, hd, flash, iscsi, ...]). true > Then what you suggest should be done for every block device that can > have bad blocks (that is, every block device). Again, this is a > filesystem issue. And of which file system type, as there are many? yes, it is a cooperation between the file system layer, and the raid layer, I propose this be done in userland. > The Bad Block Log allows md to behave 'like' a read hard disk would do > with smart data: > - unreadable blocks/stripes are recorded into the log, as unreadable > sectors are recorder into smart data > - unrecoverable read errors are reported to the caller for both > - the device still works if it has unrecoverable read errors for both > (now the whole md device fails, this is the problem) > - if a block/stripe if rewritten with success the block/stripe is > removed from Bad Block Log (and the counter of relocated blocks/stripes > is incremented); as if a sector is rewritten with succes on a disk the > sector is removed from list of unreadable sector, and the counter of > relocated sector is incremented (smart data) Smart drives also reallocate bad blocks, hiding the errors from the SW level. > A filesystem on a disk does not know what the firmware of the disk does > about sectors relocation. > The same applies for a hardware (not fake) raid controller firmware. > The same should apply for md. It is transparent to the filesystem. Yes, normally the raid layer and the fs layer are independent. But you can add better recovery with what I suggest. > IMHO a more interesting issue whould be: a write error occurs on a disk > participating to an already degraded array; failing the disk would fail > the whole array. What to do? Put the array into read only mode, still > allowing read access to data on it for easy backup? In such situation, > what would do a hardware raid controller? > > Hm, yes.... how do behave hardware raid controllers with uncorrectable > read errors? > And how they behave with write error on a disk of an already degraded array? > I guess md should replicate these behaviours. I think we should be more intelligent than ordinary HW RAID:-) Best regards keld -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
