On Mon, 14 Feb 2011 11:19:24 +0000 "Czarnowska, Anna" <anna.czarnowska@xxxxxxxxx> wrote: > Hi Neil, > I can't fully agree with you. > Loading orom in validate_geometry_imsm is a good idea but > it will only work when -e imsm option is given. > When we have an imsm container with sda and sdb and just call > mdadm -CR v0 -l 0 -n 2 /dev/sd[ab] > then default geometry will not be called and chunk will still be set to 512. > We need to realize that /dev/sda is already in an imsm container to get the correct setting. OK. How about we treat it the same way as 'layout'? So if we set a default, we also set a var called 'do_default_chunk' and then in the same places where we check do_default_layout, we also check do_default_chunk and apply a similar st-specific default. Longer term, I think I would like to check validate_geometry to pass layout and chunksize by reference and if they are UnSet, validate_geometry can set defaults. Then we can get rid of ->default_geometry. Thanks, NeilBrown -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
