Re: [PATCH 0/2] FIX: Process hangs at wait_barrier

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 04 Feb 2011 14:18:18 +0100 Krzysztof Wojcik
<krzysztof.wojcik@xxxxxxxxx> wrote:

> Patches resolve problem with process crash at wait_barrier()
> after raid0->raid10 takeover.
> First patch resolve this particular problem.
> Solution is similar to RAID1 barrier implementation.
> Second is proposal for general protection against barrier
> become negative.
> 
> ---
> 
> Krzysztof Wojcik (2):
>       FIX: md: process hangs at wait_barrier after 0->10 takeover

Applied, thanks.


>       FIX: md: Prevent barrier become negative

If we ever trying to make 'barrier' negative, that is a bug somewhere.
So I would prefer:

   BUG_ON(conf->barrier <= 0);
   conf->barrier--;

NeilBrown


> 
> 
>  drivers/md/raid1.c  |    3 ++-
>  drivers/md/raid10.c |    9 ++++++---
>  2 files changed, 8 insertions(+), 4 deletions(-)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux