> -----Original Message----- > From: Neil Brown [mailto:neilb@xxxxxxx] > Sent: Wednesday, June 16, 2010 6:51 AM > To: Kwolek, Adam > Cc: linux-raid@xxxxxxxxxxxxxxx; Williams, Dan J; Ciechanowski, Ed > Subject: Re: [md PATCH 1/5] md: Fix: max_disks limit set for external > metadata > > On Wed, 9 Jun 2010 15:20:37 +0100 > "Kwolek, Adam" <adam.kwolek@xxxxxxxxx> wrote: > > > (md: Online Capacity Expansion for IMSM) If max_disks limit is not > > set, md doesn't allow for reconfiguration and starting reshape. For > external metadata this limit is not set. > > It is set for native meta during metadata reading. > > Limit max_disks is not used for external meta, so we can set it to > value (MD_SB_DISKS) that will not block reshape. > > --- > > > > drivers/md/md.c | 2 ++ > > 1 files changed, 2 insertions(+), 0 deletions(-) > > > > diff --git a/drivers/md/md.c b/drivers/md/md.c index dfbba92..9cec771 > > 100644 > > --- a/drivers/md/md.c > > +++ b/drivers/md/md.c > > @@ -5380,6 +5380,8 @@ static int update_raid_disks(mddev_t *mddev, > int raid_disks) > > /* change the number of raid disks */ > > if (mddev->pers->check_reshape == NULL) > > return -EINVAL; > > + if (mddev->external) > > + mddev->max_disks = MD_SB_DISKS; > > if (raid_disks <= 0 || > > raid_disks >= mddev->max_disks) > > return -EINVAL; > > > > > commit 233fca36bb439eadcad28500b5139fed7c64a0ae > should make this unnecessary. > > NeilBrown Yes, you are right. Commit you pointed makes this patch unnecessary. BR Adam -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
