> -----Original Message----- > From: Neil Brown [mailto:neilb@xxxxxxx] > Sent: Wednesday, June 16, 2010 6:40 AM > To: Trela, Maciej > Cc: linux-raid@xxxxxxxxxxxxxxx; Williams, Dan J; Ciechanowski, Ed > Subject: Re: [PATCH 3/3] md: fix invalid dev slots after takeover > > On Tue, 15 Jun 2010 09:36:36 +0100 > "Trela, Maciej" <Maciej.Trela@xxxxxxxxx> wrote: > > > From: Maciej Trela <maciej.trela@xxxxxxxxx> > > > > While raid10->raid0 takeover incorrect slot numbers are set for > raid0. This was caused by invalidating dev slot numbers before calling > pers->run(). We are invalidating all devs that has (rdev->raid_disk >= > mddev->raid_disks) but rdev->raid_disk numbers are scaled in pers- > >run(). > > > > Another option to fix the problem: > > If invalidating devs should rather be performed before run() we could > use devlist[index] for invalidating - devlist is already updated after > calling takeover... > > Thanks. I see the problem but don't really like the fix. > > I propose the following (Which includes the 2/3 patch - all part of the > same > big problem really). > It looks good to me. ports and sysfs links are updating correctly now. While testing the patch I've found two minor issues/enhancements for takeover. I'll sent them in a minute along with reworked 1/3 "new_layout" fix. Maciek. -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
