----- Message from neilb@xxxxxxx ---------
Date: Mon, 14 Jun 2010 09:15:18 +1000
From: Neil Brown <neilb@xxxxxxx>
Subject: Re: Problem re-shaping RAID6
To: Jérôme Poulin <jeromepoulin@xxxxxxxxx>
Cc: linux-raid <linux-raid@xxxxxxxxxxxxxxx>
Thanks.
I fixed this bug a slightly different way
- blocks = ochunk/512 * nchunk/512 * odata * ndata / a;
+ blocks = (ochunk/512) * (nchunk/512) * odata * ndata / a;
See
http://neil.brown.name/git?p=mdadm;a=commitdiff;h=200871adf9e15d5ad985f28c349fd89c386ef48a
Those static numbers always make my nose wrinkle.
Don't we have the blocksize somewhere already? I'm also concerned what
happens when true 4k sectors are used..
========================================================================
# _ __ _ __ http://www.nagilum.org/ \n icq://69646724 #
# / |/ /__ ____ _(_) /_ ____ _ nagilum@xxxxxxxxxxx \n +491776461165 #
# / / _ `/ _ `/ / / // / ' \ Amiga (68k/PPC): AOS/NetBSD/Linux #
# /_/|_/\_,_/\_, /_/_/\_,_/_/_/_/ Mac (PPC): MacOS-X / NetBSD /Linux #
# /___/ x86: FreeBSD/Linux/Solaris/Win2k ARM9: EPOC EV6 #
========================================================================
----------------------------------------------------------------
cakebox.homeunix.net - all the machine one needs..
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html