On Tue, 11 May 2010 11:06:48 -0700 Dan Williams <dan.j.williams@xxxxxxxxx> wrote: > On Sun, Jan 18, 2009 at 4:07 PM, Neil Brown <neilb@xxxxxxx> wrote: > > On Thursday January 8, dan.j.williams@xxxxxxxxx wrote: > >> The BUG_ON(mddev->ro == 1) in md_write_start can be triggered under two > >> circumstances in recent kernels. One was reported by Justin Maggard: > > > > Hi Dan, > > Thanks for following up with this..... > > > > (I meant to send this over a week ago, but I've been on vaction > > in Tasmania and my mobile has no coverage....) > > > [..] > >> md: set mddev readonly flag on blkdev BLKROSET ioctl > > > > This one I'm happy with. I'll make sure it gets through. > > This slippery bugger seems to have evaded upstream, do you want me to resend? No thanks, the link below is good enough. That patch is now in my for-next branch and will go for-linus in 2.6.whatevercomesnext. I normally stick that sort of thing somewhere in my stack before replying that "I will make it so". I guess I failed that time. > > Here is a link for reference: > http://marc.info/?l=linux-raid&m=123139948817348&w=2 > > I have seen another report of the md_write_start() BUG_ON triggering > so I'm wondering if there are other ways for mddev->ro and > bdev->bd_part->policy to get out of sync, or if they are just hitting > the bug that this patch fixes? Maybe we should just get rid of the BUG_ON?? Let's set how it goes once this patch is really in. Thanks, NeilBrown -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
