Re: raid1.c read_balance() LBD issue?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 4/22/2010 1:21 PM, I wrote:
> raid1.c's read_balance() function has:
> 
>         const unsigned long this_sector = r1_bio->sector;
> 
> Doesn't that need to be:
> 
>         const sector_t this_sector = r1_bio->sector;
> 
> for compatibility with LBD on 32-bit platforms?

Any comments on this?

At very least it appears the truncation to 32 bits will break the "disk
whose head is closest" logic.

-- 
Jordan Russell
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux