Thanks. This is now in my queue. I may even submit it for .34 as that doesn't seem as close as I thought. NeilBrown On Wed, 05 May 2010 21:17:53 +0200 "Gabriele A. Trombetti" <g.trombetti.lkrnl1213@xxxxxxxxxxxxxxx> wrote: > Fix: md raid-6 was not trying to correct a read-error when in > singly-degraded state and was instead dropping one more device, going to > doubly-degraded state. This patch fixes this behaviour. > > Tested-by: Janos Haar <janos.haar@xxxxxxxxxxxx> > Signed-off-by: Gabriele A. Trombetti <g.trombetti.lkrnl1213@xxxxxxxxxxxxxxx> > Reported-by: Janos Haar <janos.haar@xxxxxxxxxxxx> > -------- > --- linux-2.6.34-rc5-git8-vanilla/drivers/md/raid5.c 2010-04-28 > 13:05:03.000000000 +0200 > +++ linux-2.6.34-rc5-git8/drivers/md/raid5.c 2010-04-28 > 13:08:15.000000000 +0200 > @@ -1527,7 +1527,7 @@ static void raid5_end_read_request(struc > > clear_bit(R5_UPTODATE, &sh->dev[i].flags); > atomic_inc(&rdev->read_errors); > - if (conf->mddev->degraded) > + if (conf->mddev->degraded >= conf->max_degraded) > printk_rl(KERN_WARNING > "raid5:%s: read error not correctable " > "(sector %llu on %s).\n", > > --------------------------------------------------------------- > > Resending patch: > v2: added "Tested-by" line, subsystem mentioned in summary line, body > explanation mentions "md" > > Thanks, > Gabriele A. Trombetti -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
