Re: More Hot Unplug/Plug work

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Apr 28, 2010 at 01:47:55PM -0400, Doug Ledford wrote:
DOMAIN path=pci-0000:00:1f.2-scsi-[2345]:0:0:0 action=partition
	table=/etc/mdadm.table program=sfdisk
i admit i did not take the time to pull from your git, so tell me to
rtfc if needed.
it seems you are assuming program will take table as stdin.
would not it be better to use somethink like
action=initialize command="sfdisk %d < /etc/mdadm.table" ?
where command is invoked via a shell and %d is replaced with the device
node. (more escapes could also be useful, e.g. the sysfs node)

besides that is there any provisioning to check that the device really
is empty before running action?

Regards,
L.



--
Luca Berra -- bluca@xxxxxxxxxx
        Communication Media & Services S.r.l.
 /"\
 \ /     ASCII RIBBON CAMPAIGN
  X        AGAINST HTML MAIL
 / \
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux