On Tuesday August 11, akpm@xxxxxxxxxxxxxxxxxxxx wrote: > On Tue, 4 Aug 2009 08:03:52 +1000 (EST) > "NeilBrown" <neilb@xxxxxxx> wrote: > > > On Tue, August 4, 2009 6:54 am, Sage Weil wrote: > > > The kzalloc mempool does not re-zero items that have been used and then > > > returned to the pool. Manually zero the allocated multipath_bh instead. > > > > > > CC: linux-raid@xxxxxxxxxxxxxxx > > > CC: Neil Brown <neilb@xxxxxxx> > > > CC: <stable@xxxxxxxxxx> > > Sage, why did you cc stable@xxxxxxxxxx? The patch fixes some bug? > What is it? Why is the fix sufficiently important to warrant > backporting? > > > Acked-by: NeilBrown <neilb@xxxxxxx> > > > > Thanks, I'll merge it once the above is understood. > > > > > In fact, you don't even need the memset. After allocation > > no assumptions are made about the content of the structure. > > Every field is immediately initialised except retry_list, which > > is never accessed until after the object is placed on a list.h list. > > > > So this code never needed kzalloc_pool. > > Well, that's a bit of a functional change so let us (ie: you ;)) do > that separately? Yes, I'll keep an eye out for your change to be merged, then I'll apply mine. NeilBrown -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
