On Tue, 23 Jun 2009, Nicolas Pitre wrote: > On Tue, 23 Jun 2009, Saeed Bishara wrote: > > > > > > > > > > > Can you expand the changelog to explain why this patch is needed and > > > > summarize what it does? Also, releasing patches this late in the merge > > Here is the patch with more explanation: > > ----------------------------------------< > > >From c999ed53a913979f1739854cb7c881a9dde980c6 Mon Sep 17 00:00:00 2001 > > From: Saeed Bishara <saeed@xxxxxxxxxxx> > > Date: Tue, 12 May 2009 13:29:34 +0300 > > Subject: [PATCH 1/2 v2] mv_xor: add support for clkdev framework > > > > When the clkdev framework is enabled, the device's clock is gated > > by default, this patch uses the framework to enable the clock > > when using the driver loaded and disables it when unloading the > > driver. > > Can't you be more agressive with clock gating? > > Like using clk_get() when loading the driver and clk_put() when > unloading, but using clk_enable()/clk_disable() only when a DMA channel > is actually requested or active. I agree with your suggestion, I'll add it to my todo list :). however, I think that this should be managed by the DMA engine stack, low level drivers should only provide the run time suspend/resume functions, I think that can be done on top of the runtime PM framework, see http://lwn.net/Articles/336729/ > Nicolas > -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
