On Thu, Mar 19, 2009 at 1:10 PM, Andre Noll <maan@xxxxxxxxxxxxxxx> wrote: > On 12:20, Dan Williams wrote: > >> Using src_list argument of async_xor() as a storage for dma addresses >> implies sizeof(dma_addr_t) <= sizeof(struct page *) restriction which is >> not always true (e.g. ppc440spe). > > This message does not tell what the patch is going to do about that. > It would also be nice to mention (either in the log message or as a > comment) why allocating the dma_src arrays on the stack is not going > to be a problem. > True, and taking into account your other comment about the number of parameters I think this is a good opportunity to solve this problem rather than kick it down the road. So I will prepare a rework to make this memory caller provided. This gives us the flexibility to use a kmalloc'd buffer hanging off the stripe_head as Neil suggested in another thread. Regards, Dan -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
