Re: [PATCH 2.6.29-rc7] md: fix deadlock when stopping arrays

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday March 5, dan.j.williams@xxxxxxxxx wrote:
> Resolve a deadlock when stopping redundant arrays, i.e. ones that
> require a call to sysfs_remove_group when shutdown.  The deadlock is
> summarized below:
> 
> Thread1                Thread2
> -------                -------
> read sysfs attribute   stop array
>                        take mddev lock
>                        sysfs_remove_group
> sysfs_get_active
> wait for mddev lock
>                        wait for active

Thanks.

It's pretty sneaking overloading ->private to let mddev_delayed_delete
know that it has something else to do ... wish I'd thought of it :-)

Can you add 
   Cc: stable@xxxxxxxxxx
at the bottom.  Then I'll pull it and send a pull request to Linus.  I
think it should go straight in.

[If a commit contains "cc: stable@xxxxxxxxxx" then the "stable team"
will automatically notice it as soon as Linus pulls it - no need to
bother them with extra email.]

Thanks.
NeilBrown
--
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux