On Saturday 2009-01-17 22:37, David Woodhouse wrote: >On Sun, 2009-01-18 at 01:47 +0530, Jaswinder Singh Rajput wrote: >> --- a/include/linux/dvb/audio.h >> +++ b/include/linux/dvb/audio.h >> @@ -24,9 +24,8 @@ >> #ifndef _DVBAUDIO_H_ >> #define _DVBAUDIO_H_ >> >> -#ifdef __KERNEL__ >> #include <linux/types.h> >> -#else >> +#ifndef __KERNEL__ >> #include <stdint.h> >> #endif > >That patch looks wrong, and unnecessary. It was fine before. What itches my eye is #ifndef __KERNEL__ #include <stdint.h> #endif I am not sure how much Linux header files are supposed to be usable from C++, but in case someone does, <cstdint> should be used in C++0x mode. Testing for C++0x with macros however looks even more out of place in such header files. Thoughts? -- To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
