Re: Bug#444682: [PATCH] Fix segfault on assembly on amd64 with v1 superblocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



I've tested this patch and it works :)

Daniel


On Sun, 2007-09-30 at 13:22 +0100, martin f. krafft wrote:
> Commit a40b4fe introduced a temporary supertype variable tst, instead of
> manipulating st directly. However, it was forgotton to pass &tst into the
> recursive load_super1 call, causing an infinite recursion.
> 
> Signed-off-by: martin f. krafft <madduck@xxxxxxxxxx>
> ---
>  super1.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/super1.c b/super1.c
> index 52783e7..06c2655 100644
> --- a/super1.c
> +++ b/super1.c
> @@ -1001,7 +1001,7 @@ static int load_super1(struct supertype *st, int fd, void **sbp, char *devname)
>  		/* guess... choose latest ctime */
>  		tst.ss = &super1;
>  		for (tst.minor_version = 0; tst.minor_version <= 2 ; tst.minor_version++) {
> -			switch(load_super1(st, fd, sbp, devname)) {
> +			switch(load_super1(&tst, fd, sbp, devname)) {
>  			case 0: super = *sbp;
>  				if (bestvers == -1 ||
>  				    bestctime < __le64_to_cpu(super->ctime)) {

-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux