On Thursday May 10, akpm@xxxxxxxxxxxxxxxxxxxx wrote:
> On Thu, 10 May 2007 16:22:31 +1000 NeilBrown <neilb@xxxxxxx> wrote:
>
> > The test currently looks for any (non-fuzz) difference, either
> > positive or negative. This clearly is not needed. Any non-sync
> > activity will cause the total sectors to grow faster than the sync_io
> > count (never slower) so we only need to look for a positive differences.
> >
> > ...
> >
> > --- .prev/drivers/md/md.c 2007-05-10 15:51:54.000000000 +1000
> > +++ ./drivers/md/md.c 2007-05-10 16:05:10.000000000 +1000
> > @@ -5095,7 +5095,7 @@ static int is_mddev_idle(mddev_t *mddev)
> > *
> > * Note: the following is an unsigned comparison.
> > */
> > - if ((curr_events - rdev->last_events + 4096) > 8192) {
> > + if ((long)curr_events - (long)rdev->last_events > 4096) {
> > rdev->last_events = curr_events;
> > idle = 0;
>
> In which case would unsigned counters be more appropriate?
I guess.....
It is really the comparison that I want to be signed, I don't much
care about the counted - they are expected to wrap (though they might
not).
So maybe I really want
if ((signed long)(curr_events - rdev->last_events) > 4096) {
to make it clear...
But people expect number to be signed by default, so that probably
isn't necessary.
Yeah, I'll make them signed one day.
Thanks,
NeilBrown
-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
