On Friday 16 March 2007 09:29, Benjamin Herrenschmidt wrote: > > + /* > > + * Map registers > > + */ > > + i2o_reg = (i2o_regs_t *)ioremap64(I2O_MMAP_BASE, I2O_MMAP_SIZE); > > + dma_reg0 = (dma_regs_t *)ioremap64(DMA0_MMAP_BASE, DMA_MMAP_SIZE); > > + dma_reg1 = (dma_regs_t *)ioremap64(DMA1_MMAP_BASE, DMA_MMAP_SIZE); > > + xor_reg = (xor_regs_t *)ioremap64(XOR_MMAP_BASE,XOR_MMAP_SIZE); > > You should test the result of these. Also, the move to arch/powerpc here > as well will cleanup as ioremap will always take 64 bits resource_size_t > (can't you make that working on arch/ppc too and use normal ioremap > there as well ?). It's quite easy: Just configure CONFIG_RESOURCES_64BIT and you can use the "normal" ioremap(). Wolfgang, please give it a try. It already works on the Katmai and Taishan. > > + /* > > + * Configure h/w > > + */ > > + > > + /* Reset I2O/DMA */ > > + mtdcr(DCRN_SDR0_CFGADDR, 0x200); > > + mtdcr(DCRN_SDR0_CFGDATA, 0x10000); > > + mtdcr(DCRN_SDR0_CFGADDR, 0x200); > > + mtdcr(DCRN_SDR0_CFGDATA, 0x0); > > The above could use some symbolic constants... Is this the only piece of > code to access the SDR0 indirect config registers ? If not, then some > global locking is needed as well. Please add #define DCRN_SDR0_SRST0 0x200 #define SDR0_SRST_I2ODMA (0x80000000 > 15) to include/asm-ppc/ppc44x.h and then use SDR_WRITE(DCRN_SDR0_SRST0, SDR0_SRST_I2ODMA); SDR_WRITE(DCRN_SDR0_SRST0, 0); here. Best regards, Stefan ===================================================================== DENX Software Engineering GmbH, HRB 165235 Munich, CEO: Wolfgang Denk Office: Kirchenstr. 5, D-82194 Groebenzell, Germany ===================================================================== - To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
