On 14 Jan 2007, Neil Brown told this: > A quick look suggests that the following patch might make a > difference, but there is more to it than that. I think there are > subtle differences due to the use of version-1 superblocks. That > might be just another one-line change, but I want to make sure first. Well, that certainly made that warning go away. I don't have any actually-failed disks, so I can't tell if it would *ever* warn anymore ;) ... actually, it just picked up some monthly array check activity: Jan 15 20:03:17 loki daemon warning: mdadm: Rebuild20 event detected on md device /dev/md2 So it looks like it works perfectly well now. (Looking at the code, yeah, without that change it'll never remember state changes at all!) One bit of residue from the state before this patch remains on line 352, where you initialize disc.state and then never use it for anything... -- `He accused the FSF of being "something of a hypocrit", which shows that he neither understands hypocrisy nor can spell.' --- jimmybgood - To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html