Neil Brown wrote:
[]
> Fix count of degraded drives in raid10.
>
> Signed-off-by: Neil Brown <neilb@xxxxxxx>
>
> --- .prev/drivers/md/raid10.c 2006-10-09 14:18:00.000000000 +1000
> +++ ./drivers/md/raid10.c 2006-10-05 20:10:07.000000000 +1000
> @@ -2079,7 +2079,7 @@ static int run(mddev_t *mddev)
> disk = conf->mirrors + i;
>
> if (!disk->rdev ||
> - !test_bit(In_sync, &rdev->flags)) {
> + !test_bit(In_sync, &disk->rdev->flags)) {
> disk->head_position = 0;
> mddev->degraded++;
> }
Neil, this makes me nervous. Seriously.
How many bugs like this has been fixed so far? 10? 50? I stopped counting
long time ago. And it's the same thing in every case - misuse of rdev vs
disk->rdev. The same pattern.
I wonder if it can be avoided in the first place somehow - maybe don't
declare and use local variable `rdev' (not by name, but by the semantics
of it), and always use disk->rdev or mddev->whatever in every place,
explicitly, and let the compiler optimize the deref if possible?
And btw, this is another 2.6.18.1 candidate (if it's not too late already).
Thanks.
/mjt
-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
