Hi, On Mon, 11 Sep 2006 16:19:00 -0700 Dan Williams <dan.j.williams@xxxxxxxxx> wrote: > From: Dan Williams <dan.j.williams@xxxxxxxxx> > > This is a driver for the iop DMA/AAU/ADMA units which are capable of pq_xor, > pq_update, pq_zero_sum, xor, dual_xor, xor_zero_sum, fill, copy+crc, and copy > operations. You implement a bunch of different functions here. I agree with Jeff's feedback related to the lack of scalability the way the API is going right now. Another example of this is that the driver is doing it's own self-test of the functions. This means that every backend driver will need to duplicate this code. Wouldn't it be easier for everyone if the common infrastructure did a test call at the time of registration of a function instead, and return failure if it doesn't pass? > drivers/dma/Kconfig | 27 + > drivers/dma/Makefile | 1 > drivers/dma/iop-adma.c | 1501 +++++++++++++++++++++++++++++++++++ > include/asm-arm/hardware/iop_adma.h | 98 ++ ioatdma.h is currently under drivers/dma/. If the contents is strictly device-related please add them under drivers/dma. -Olof - To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
