On Saturday August 12, 76306.1226@xxxxxxxxxxxxxx wrote:
> Doing this on a raid1 array:
> echo "check" >/sys/block/md0/md/sync_action
>
> On 2.6.16.27:
> Activity lights on both mirrors show activity for a while,
> then the array status prints on the console.
>
> On 2.6.18-rc4 + the below patch:
> Drive activity light blinks once on one drive, then the
> array status prints (obviously no checking takes place.)
>
Thanks for the report.
Easily duplicated, easily fixed.
I'll make sure this patch gets into 2.6.18.
Thanks again,
NeilBrown
Signed-off-by: Neil Brown <neilb@xxxxxxx>
diff .prev/drivers/md/raid1.c ./drivers/md/raid1.c
--- .prev/drivers/md/raid1.c 2006-07-31 17:24:36.000000000 +1000
+++ ./drivers/md/raid1.c 2006-08-14 15:52:48.000000000 +1000
@@ -1644,15 +1644,16 @@ static sector_t sync_request(mddev_t *md
return 0;
}
- /* before building a request, check if we can skip these blocks..
- * This call the bitmap_start_sync doesn't actually record anything
- */
if (mddev->bitmap == NULL &&
mddev->recovery_cp == MaxSector &&
+ !test_bit(MD_RECOVERY_REQUESTED, &mddev->recovery) &&
conf->fullsync == 0) {
*skipped = 1;
return max_sector - sector_nr;
}
+ /* before building a request, check if we can skip these blocks..
+ * This call the bitmap_start_sync doesn't actually record anything
+ */
if (!bitmap_start_sync(mddev->bitmap, sector_nr, &sync_blocks, 1) &&
!conf->fullsync && !test_bit(MD_RECOVERY_REQUESTED, &mddev->recovery)) {
/* We can skip this block, and probably several more */
-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
