Re: [PATCH] ANNOUNCE: mdadm 2.5.1 - A tool for managing Soft RAID under Linux

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Monday June 19, paul.clements@xxxxxxxxxxxx wrote:
> > Neil Brown wrote:
> > I am pleased to announce the availability of
> >    mdadm version 2.5.1
> 
> What the heck, here's another one. :) This one is slightly more serious. 
> We're getting a device of "0:0" in "Fail" events from the mdadm monitor 
> sometimes now (due to the change in map_dev, which allows it to 
> sometimes return "0:0" instead of just NULL for an unknown device).
> 

Thanks for this and the other two.  They are now in .git

> The patch fixes my issue. I don't know if there are more.
> 

I chose to do this differently - map_dev will now return NULL for 0,0
and all users can cope with a NULL.

NeilBrown



> Thanks,
> Paul
> --- mdadm-2.5.1/Monitor.c	Thu Jun  1 21:33:41 2006
> +++ mdadm-2.5.1-new/Monitor.c	Mon Jun 19 14:51:31 2006
> @@ -328,7 +328,7 @@ int Monitor(mddev_dev_t devlist,
>  					}
>  					disc.major = disc.minor = 0;
>  				}
> -				if (dv == NULL && st->devid[i])
> +				if ((dv == NULL || strcmp(dv, "0:0") == 0) && st->devid[i])
>  					dv = map_dev(major(st->devid[i]),
>  						     minor(st->devid[i]), 1);
>  				change = newstate ^ st->devstate[i];
-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux RAID Wiki]     [ATA RAID]     [Linux SCSI Target Infrastructure]     [Linux Block]     [Linux IDE]     [Linux SCSI]     [Linux Hams]     [Device Mapper]     [Device Mapper Cryptographics]     [Kernel]     [Linux Admin]     [Linux Net]     [GFS]     [RPM]     [git]     [Yosemite Forum]


  Powered by Linux