On Tue, 30 May 2006, Neil Brown wrote:
> Could you try this patch please? On top of the rest.
> And if it doesn't fail in a couple of days, tell me how regularly the
> message
> kblockd_schedule_work failed
> gets printed.
i'm running this patch now ... and just after reboot, no freeze yet, i've
already seen a handful of these:
May 30 17:05:09 localhost kernel: kblockd_schedule_work failed
May 30 17:05:59 localhost kernel: kblockd_schedule_work failed
May 30 17:08:16 localhost kernel: kblockd_schedule_work failed
May 30 17:10:51 localhost kernel: kblockd_schedule_work failed
May 30 17:11:51 localhost kernel: kblockd_schedule_work failed
May 30 17:12:46 localhost kernel: kblockd_schedule_work failed
May 30 17:14:14 localhost kernel: kblockd_schedule_work failed
-dean
>
> Thanks,
> NeilBrown
>
>
> Signed-off-by: Neil Brown <neilb@xxxxxxx>
>
> ### Diffstat output
> ./block/ll_rw_blk.c | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff ./block/ll_rw_blk.c~current~ ./block/ll_rw_blk.c
> --- ./block/ll_rw_blk.c~current~ 2006-05-30 09:48:02.000000000 +1000
> +++ ./block/ll_rw_blk.c 2006-05-30 09:48:48.000000000 +1000
> @@ -1636,7 +1636,11 @@ static void blk_unplug_timeout(unsigned
> {
> request_queue_t *q = (request_queue_t *)data;
>
> - kblockd_schedule_work(&q->unplug_work);
> + if (!kblockd_schedule_work(&q->unplug_work)) {
> + /* failed to schedule the work, try again later */
> + printk("kblockd_schedule_work failed\n");
> + mod_timer(&q->unplug_timer, jiffies + q->unplug_delay);
> + }
> }
>
> /**
> -
> To unsubscribe from this list: send the line "unsubscribe linux-raid" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
