On Saturday March 18, francois.barre@xxxxxxxxx wrote: > > > Ok, look again, under > > > http://cgi.cse.unsw.edu.au/~neilb/patches/linux-devel/ > > > > > Early comments : > I tested with patch-all-2006-03-17-10 on top of 2.6.16-rc6-mm1. > I had two compilation issues : > * in include/linux/raid/md_k.h, external is not defined in mddev_s. I > supposed it was an int. > > * in drivers/raid/md.c and include/linux/raid/md.h, md_do_sync is > confused, being declared static, but used in other places, like > raid5.c. I supposed it shall be declared non-static. > > With these 2 modifications, compilation is ok. Yes... If you grabbed all the patches, it would have included some that I haven't worked on for a while, and haven't tested recently either... I'll do another patch set in a day or so with these fixed up. > > Raid5 resize testing : > I tried using it with 4 loop devices, creating a 3 10Mb raid5 and adding a 4th. > - mdadm -C -n 3 -l 5 /dev/md1 /dev/loop[123] : no problem > - mdadm -a /dev/md1 /dev/loop4 : loop4 is a spare > - mdadm -G -n 4 /dev/md1 returns error, but nothing happens : the 4th > is not added, and stays as a spare. md1 is still accessible, no > problem about that. That is deliberate. You need a new version of mdadm to use raid5-reshape safely. A pre-release will be out soon. NeilBrown - To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html