NeilBrown <neilb@xxxxxxx> wrote:
>
> diff ./drivers/md/raid5.c~current~ ./drivers/md/raid5.c
> --- ./drivers/md/raid5.c~current~ 2006-03-17 11:48:58.000000000 +1100
> +++ ./drivers/md/raid5.c 2006-03-17 11:48:58.000000000 +1100
> @@ -1747,8 +1747,9 @@ static int make_request(request_queue_t
That's a fairly complex function..
I wonder about this:
spin_lock_irq(&conf->device_lock);
if (--bi->bi_phys_segments == 0) {
int bytes = bi->bi_size;
if ( bio_data_dir(bi) == WRITE )
md_write_end(mddev);
bi->bi_size = 0;
bi->bi_end_io(bi, bytes, 0);
}
spin_unlock_irq(&conf->device_lock);
bi_end_io() can be somewhat expensive. Does it need to happen under the lock?
-
To unsubscribe from this list: send the line "unsubscribe linux-raid" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
