On Wed, Nov 02, 2005 at 09:15:10PM +1100, NeilBrown wrote: > > 1/ I really should be using the __ATTR macros for defining attributes, so > that the .owner field get set properly, otherwise modules can be removed > while sysfs files are open. > This also involves some name changes of _show routines. > > 2/ Always lock the mddev (against reconfiguration) for all sysfs > attribute access. This easily avoid certain races and is completely > consistant with other interfaces (ioctl and /proc/mdstat both > always lock against reconfiguration). > > 3/ raid5 attributes must check that the 'conf' structure actually > exists (the array could have been stopped while an attribute file > was open). > > 4/ A missing 'kfree' from when the raid5_conf_t was converted to have > a kobject embedded, and then converted back again. > > > > Signed-off-by: Neil Brown <neilb@xxxxxxx> Acked-by: Greg Kroah-Hartman <gregkh@xxxxxxx> - To unsubscribe from this list: send the line "unsubscribe linux-raid" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
